Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid Address when clicking the Etherscan Token Link for ERC721 Approve screen #6058

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Invalid Address when clicking the Etherscan Token Link for ERC721 Approve screen #6058

merged 1 commit into from
Apr 5, 2023

Conversation

blackdevelopa
Copy link
Contributor

@blackdevelopa blackdevelopa commented Mar 28, 2023 •
edited

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description
When I click on the ERC721 token name from the Approve screen, we land on the Etherscan Invalid Address page.

Screenshots/Recordings
Before:
https://recordit.co/yKuQVM1Hr2

After:
http://recordit.co/gZUsWpPooY

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #6055

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@blackdevelopa blackdevelopa requested a review from a team as a code owner March 28, 2023 12:23
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team labels Mar 28, 2023
@seaona
Copy link
Contributor

seaona commented Apr 3, 2023

From QA looks good @blackdevelopa . Whenever we have 2 dev approvals I can merge the PR.

approve-link-blockexplorer.mp4

@blackdevelopa blackdevelopa self-assigned this Apr 3, 2023
@blackdevelopa blackdevelopa mentioned this pull request Apr 5, 2023
Merged
3 tasks
NiranjanaBinoy
NiranjanaBinoy approved these changes Apr 5, 2023
View reviewed changes
Copy link

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seaona seaona added QA Passed A successful QA run through has been done and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Apr 5, 2023
@seaona seaona merged commit 3b46059 into main Apr 5, 2023
@seaona seaona deleted the bgfix/6055 branch April 5, 2023 15:59
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2023
@seaona seaona added the release-6.4.0 PR for release 6.4.0 label Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpuri jpuri jpuri approved these changes

@NiranjanaBinoy NiranjanaBinoy NiranjanaBinoy approved these changes

Assignees

@blackdevelopa blackdevelopa

Labels
QA Passed A successful QA run through has been done release-6.4.0 PR for release 6.4.0 team-confirmations-secure-ux-PR PR from the confirmations team unit test coverage confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@blackdevelopa @seaona @jpuri @NiranjanaBinoy @hilvmason