Refactor send transaction v2 #6060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method handler for `eth_sendTransaction` has been moved to a separate module to simplify unit testing. Unit tests have been added as well. This module was written in TypeScript, which asked for some additional validation of the method parameters. We now throw a more explicit message when the params are missing, and when the transaction parameters are not an object. Previously the method would still throw an error in these scenarios, just with a less helpful message. The change in error message should be the only functional change here. This refactor is intended to make testing PR #5619 easier.
The Metro configuration has been updated to support `.cjs` file extensions. The `@metamask/utils` dependency relies upon the library `superstruct` which uses `.cjs` for its main exported module.
The two functions taken from `@metamask/utils` have been inlined as a workaround to an error that gets thrown upon import on Android builds. I'm still actively investigating that failure, so hopefully we can replace these inlined functions soon.
Gudahtt
force-pushed
the
refactor-send-transaction-v2
branch
from
b8a5d09
to
3d6b6a0
Compare
Gudahtt
added
the
needs-dev-review
Cal-L
added
Spot Check on the Release Build
chrisleewilcox
added
needs-qa
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
This is a repeat of #5968, which was reverted in #6021 to fix a bug on Android. Investigation into that bug is ongoing, but it related to the
@metamask/utilsimport. That dependency has been replaced in this PR in the most recent commit; all previous commits are identical to the previous PR (except that they have been rebased ontomain).Original description:
The method handler for eth_sendTransaction has been moved to a separate module to simplify unit testing. Unit tests have been added as well.
This module was written in TypeScript, which asked for some additional validation of the method parameters. We now throw a more explicit message when the params are missing, and when the transaction parameters are not an object. Previously the method would still throw an error in these scenarios, just with a less helpful message. The change in error message should be the only functional change here.
Issue
This refactor is intended to make testing PR #5619 easier.
Checklist