Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Fixes WalletConnect deep links (wc:// schema) not working properly #6076

Merged
merged 4 commits into from
Apr 11, 2023
Merged

[BUGFIX] Fixes WalletConnect deep links (wc:// schema) not working properly #6076

merged 4 commits into from
Apr 11, 2023

Conversation

andreahaku
Copy link
Member

@andreahaku andreahaku commented Mar 30, 2023 •
edited

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Fixes WalletConnect deep links (wc:// schema) not working properly.

This is needed as WC is moving away from universal links (https://metamask.app.link/wc...) in favour of deep links (wc:// schema) with the new WC 2.3 modal.

To test this:
https://release-2-3-0.web3modal-dev.pages.dev/

and use WC v1 examples.

Screenshots/Recordings

image

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@andreahaku andreahaku added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) WalletConnect WalletConnect related issue or bug labels Mar 30, 2023
@andreahaku andreahaku self-assigned this Mar 30, 2023
@andreahaku andreahaku requested a review from a team as a code owner March 30, 2023 11:34
@andreahaku andreahaku added Code Impact - Low Minor code change that can safely applied to the codebase Priority - High Task with high priority labels Mar 30, 2023
NicolasMassart
NicolasMassart approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@andreahaku andreahaku added needs-qa Any New Features that needs a full manual QA prior to being added to a release. release-6.4.0 PR for release 6.4.0 and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 30, 2023
@andreahaku andreahaku mentioned this pull request Apr 4, 2023
Closed
@christopherferreira9 christopherferreira9 self-assigned this Apr 6, 2023
@christopherferreira9 christopherferreira9 added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 6, 2023
@andreahaku andreahaku force-pushed the fix/wallet_connect_deeplinks_universal_links branch from b548972 to dfac8fe Compare April 6, 2023 09:25
@christopherferreira9
Copy link
Contributor

@andreahaku I'm bumping into a few issues on iOS and Android

  • Deeplinking works perfectly
  • Scanning breaks in both Example V1 and Example V1 Extended
Screen.Recording.2023-04-06.at.17.09.05.mov

@christopherferreira9 christopherferreira9 added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed QA in Progress QA has started on the feature. labels Apr 6, 2023
@christopherferreira9 christopherferreira9 added QA Passed A successful QA run through has been done and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Apr 11, 2023
@christopherferreira9
Copy link
Contributor

christopherferreira9 commented Apr 11, 2023 •
edited

Retested the fixes and it's working properly 👌

@christopherferreira9 christopherferreira9 merged commit fd568e5 into main Apr 11, 2023
13 checks passed
@christopherferreira9 christopherferreira9 deleted the fix/wallet_connect_deeplinks_universal_links branch April 11, 2023 13:24
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
@christopherferreira9 christopherferreira9 removed the release-6.4.0 PR for release 6.4.0 label Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NicolasMassart NicolasMassart NicolasMassart approved these changes

Assignees

@andreahaku andreahaku

@christopherferreira9 christopherferreira9

Labels
Code Impact - Low Minor code change that can safely applied to the codebase Priority - High Task with high priority QA Passed A successful QA run through has been done release-6.5.0 team-mobile-platform WalletConnect WalletConnect related issue or bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andreahaku @christopherferreira9 @NicolasMassart @chrisleewilcox @gauthierpetetin