Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ESLint rules for scripts #6081

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Update ESLint rules for scripts #6081

merged 1 commit into from
Mar 30, 2023

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Mar 30, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Our ESLint rules have been updated to include override rules for scripts. Scripts run in a Node.js environment where using console.log is expected, so they rules against using Node.js imports and console.log did not make sense.

Issue

N/A, this fixes a minor development inconvenience

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@Gudahtt
Update ESLint rules for scripts
af881a4 
Our ESLint rules have been updated to include override rules for
scripts. Scripts run in a Node.js environment where using `console.log`
is expected, so they rules against using Node.js imports and
 `console.log` did not make sense.

This allows us to remove various ESLint ignore rules that were added to
scripts.
@Gudahtt Gudahtt added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 30, 2023
@Gudahtt Gudahtt marked this pull request as ready for review March 30, 2023 18:51
@Gudahtt Gudahtt requested a review from a team as a code owner March 30, 2023 18:51
owencraston
owencraston approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@owencraston owencraston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems simple enough!

@Gudahtt Gudahtt merged commit 7a3ff93 into main Mar 30, 2023
@Gudahtt Gudahtt deleted the update-eslint-script-rules branch March 30, 2023 19:06
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@owencraston owencraston owencraston approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed/E2E Only Apply this label when your PR does not need any QA effort.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gudahtt @owencraston