Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inactive IPFS gateways #6082

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Conversation

NicholasEllul
Copy link
Contributor

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description
This pull request removes IPFS gateways which are no longer up and serving over HTTPs. This is to clear out stale records which are no longer relevant to the MetaMask Mobile Application. I did not remove records for IPFS providers which were still up, but returned an incorrect response when testing if they were active.

Issue

https://github.com/MetaMask/mobile-planning/issues/766

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

For reviewers

Visit each provider and view that it is down.

List with clickable links for all downed providers

{
"value": "https://rx14.co.uk/ipfs/",
"key": 3,
"label": "https://rx14.co.uk/ipfs/"
},
{
"value": "https://ninetailed.ninja/ipfs/",
"key": 4,
"label": "https://ninetailed.ninja/ipfs/"
},
{
"value": "https://upload.global/ipfs/",
"key": 5,
"label": "https://upload.global/ipfs/"
},
{
"value": "https://ipfs.jes.xxx/ipfs/",
"key": 6,
"label": "https://ipfs.jes.xxx/ipfs/"
},
{
"value": "https://catalunya.network/ipfs/",
"key": 7,
"label": "https://catalunya.network/ipfs/"
},
{
"value": "https://siderus.io/ipfs/",
"key": 8,
"label": "https://siderus.io/ipfs/"
},
{
"value": "https://ipfs.eternum.io/ipfs/",
"key": 9,
"label": "https://ipfs.eternum.io/ipfs/"
},
{
"value": "https://ipfs.macholibre.org/ipfs/",
"key": 11,
"label": "https://ipfs.macholibre.org/ipfs/"
},
{
"value": "https://ipfs.works/ipfs/",
"key": 12,
"label": "https://ipfs.works/ipfs/"
},
{
"value": "https://ipfs.wa.hle.rs/ipfs/",
"key": 13,
"label": "https://ipfs.wa.hle.rs/ipfs/"
},
{
"value": "https://api.wisdom.sh/ipfs/",
"key": 14,
"label": "https://api.wisdom.sh/ipfs/"
},
{
"value": "https://gateway.blocksec.com/ipfs/",
"key": 15,
"label": "https://gateway.blocksec.com/ipfs/"
},
{
"value": "https://ipfs.renehsz.com/ipfs/",
"key": 16,
"label": "https://ipfs.renehsz.com/ipfs/"
},
{ "value": "https://ipns.co/", "key": 18, "label": "https://ipns.co/" },
{
"value": "https://ipfs.netw0rk.io/ipfs/",
"key": 19,
"label": "https://ipfs.netw0rk.io/ipfs/"
},
{
"value": "https://gateway.swedneck.xyz/ipfs/",
"key": 20,
"label": "https://gateway.swedneck.xyz/ipfs/"
},
{
"value": "https://ipfs.mrh.io/ipfs/",
"key": 21,
"label": "https://ipfs.mrh.io/ipfs/"
},
{
"value": "https://gateway.originprotocol.com/ipfs/",
"key": 22,
"label": "https://gateway.originprotocol.com/ipfs/"
},
{
"value": "https://ipfs.dapps.earth/ipfs/",
"key": 23,
"label": "https://ipfs.dapps.earth/ipfs/"
},
{
"value": "https://ipfs.doolta.com/ipfs/",
"key": 25,
"label": "https://ipfs.doolta.com/ipfs/"
},
{
"value": "https://ipfs.sloppyta.co/ipfs/",
"key": 26,
"label": "https://ipfs.sloppyta.co/ipfs/"
},
{
"value": "https://ipfs.busy.org/ipfs/",
"key": 27,
"label": "https://ipfs.busy.org/ipfs/"
},
{
"value": "https://gateway.serph.network/ipfs/",
"key": 29,
"label": "https://gateway.serph.network/ipfs/"
},
{
"value": "https://jorropo.ovh/ipfs/",
"key": 30,
"label": "https://jorropo.ovh/ipfs/"
},
{
"value": "https://ipfs.deo.moe/ipfs/",
"key": 31,
"label": "https://ipfs.deo.moe/ipfs/"
},
{
"value": "https://gateway.temporal.cloud/ipfs/",
"key": 32,
"label": "https://gateway.temporal.cloud/ipfs/"
},

@NicholasEllul NicholasEllul requested a review from a team as a code owner March 30, 2023 20:30
@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NicholasEllul
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@NicholasEllul NicholasEllul added release-6.4.0 PR for release 6.4.0 needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 31, 2023
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman
Copy link
Contributor

@chrisleewilcox @cortisiko This seems like a No QA needed/Smoke test in regression ticket. It just removes a few IPFS URLs in the IPFS list.

@cortisiko
Copy link
Member

@sethkfman Sounds safe enough for a smoke test. 👍 cc @chrisleewilcox @NicholasEllul

@chrisleewilcox chrisleewilcox added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. team-mobile-client labels Apr 6, 2023
@cortisiko cortisiko removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 6, 2023
@cortisiko cortisiko merged commit f340b3b into main Apr 6, 2023
@cortisiko cortisiko deleted the ellul/remove-down-ipfs-providers branch April 6, 2023 18:59
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-6.4.0 PR for release 6.4.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants