Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extracting out signature request related code from RootRPCMethodsUI conponent #6097

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Extracting out signature request related code from RootRPCMethodsUI conponent #6097

merged 3 commits into from
Apr 26, 2023

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Apr 3, 2023

Fixes: #5561

Extract signature request related code from RootRPCMethodUI.js into a react component.

QA Steps:

  • check to ensure that all signature request pages continue to work as before

@jpuri jpuri requested a review from a team as a code owner April 3, 2023 08:15
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri mentioned this pull request Apr 5, 2023
Merged
3 tasks
blackdevelopa
blackdevelopa reviewed Apr 5, 2023
View reviewed changes
Copy link
Contributor

@blackdevelopa blackdevelopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 . Just small nitpicking.

app/components/UI/SignatureRequest/Root/Root.tsx Outdated Show resolved Hide resolved
app/components/UI/SignatureRequest/Root/Root.tsx Show resolved Hide resolved
app/components/UI/SignatureRequest/Root/Root.tsx Show resolved Hide resolved
app/components/UI/SignatureRequest/Root/Root.tsx Outdated Show resolved Hide resolved
app/components/UI/SignatureRequest/Root/Root.tsx Outdated Show resolved Hide resolved
app/components/UI/SignatureRequest/types.ts Outdated Show resolved Hide resolved
app/components/Nav/Main/RootRPCMethodsUI.js Show resolved Hide resolved
@jpuri jpuri requested a review from blackdevelopa April 6, 2023 03:29
@jpuri jpuri force-pushed the signature_request_refactoring branch from c308444 to e9854f4 Compare April 7, 2023 06:52
@seaona seaona added needs-qa Any New Features that needs a full manual QA prior to being added to a release. team-confirmations-secure-ux-PR PR from the confirmations team labels Apr 13, 2023
@seaona seaona removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Apr 26, 2023
@seaona
Copy link
Contributor

seaona commented Apr 26, 2023

@jpuri PR looks good. I can see how the functionality is preserved and signatures are working.

mobile-sign.webm

@seaona seaona merged commit 3410c40 into main Apr 26, 2023
14 checks passed
@seaona seaona deleted the signature_request_refactoring branch April 26, 2023 10:12
@seaona seaona added the QA Passed A successful QA run through has been done label Apr 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2023
@seaona seaona added the release-6.6.0 PR for release 6.6.0 label Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@segun segun segun approved these changes

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-6.6.0 PR for release 6.6.0 team-confirmations-secure-ux-PR PR from the confirmations team unit test coverage confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract Signature Request code from RootRPCMethodsUI
5 participants
@jpuri @seaona @segun @blackdevelopa @hilvmason