-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Componentize BottomSheet #6106
Componentize BottomSheet #6106
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…to morph/componentize-bottomsheet
…to morph/componentize-bottomsheet
…to morph/componentize-bottomsheet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @brianacnguyen, should this be rebased? I see a lot of conflicts. It would be great to update the PR description too
…to morph/componentize-bottomsheet
…to morph/componentize-bottomsheet
…etaMask/metamask-mobile into morph/componentize-bottomsheet
app/component-library/components/BottomSheets/BottomSheetHeader/BottomSheetHeader.constants.ts
Outdated
Show resolved
Hide resolved
...brary/components/BottomSheets/BottomSheet/foundation/BottomSheetDialog/BottomSheetDialog.tsx
Outdated
Show resolved
Hide resolved
app/component-library/components/BottomSheets/BottomSheet/BottomSheet.tsx
Outdated
Show resolved
Hide resolved
…to morph/componentize-bottomsheet
...component-library/components/BottomSheets/BottomSheet/foundation/BottomSheetDialog/README.md
Outdated
Show resolved
Hide resolved
Could you also resolve checks |
…to morph/componentize-bottomsheet
…to morph/componentize-bottomsheet
…to morph/componentize-bottomsheet
…to morph/componentize-bottomsheet
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #6106 +/- ##
==========================================
- Coverage 32.83% 32.78% -0.05%
==========================================
Files 998 1001 +3
Lines 26674 26710 +36
Branches 2092 2096 +4
==========================================
Hits 8758 8758
- Misses 17498 17534 +36
Partials 418 418
☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
label when dev review is completedQA Passed
label when QA has signed offDescription
Screenshots/Recordings
![Simulator Screen Shot - iPhone 14 Pro - 2023-07-24 at 21 13 24](https://private-user-images.githubusercontent.com/14355083/255794444-dba401aa-9d0c-4d2f-bf17-3f77fc6fb0f1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE5Nzk1MzYsIm5iZiI6MTcyMTk3OTIzNiwicGF0aCI6Ii8xNDM1NTA4My8yNTU3OTQ0NDQtZGJhNDAxYWEtOWQwYy00ZDJmLWJmMTctM2Y3N2ZjNmZiMGYxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI2VDA3MzM1NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQwMDM4YmJkNzAzYTY3MTQwYzRmNTA4MzE1NTJiNjFjMjY5YWI3ZTBjMzAwMDY5NTg2NTEyMjY0ZWJjYmYxMmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.gBpBntjEkS8NC6ug2Kr4UdnHpvN85I6nFapf0PLksUY)
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses #???
Checklist