Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Componentize BottomSheet #6106

Merged
merged 22 commits into from
Aug 30, 2023
Merged

Componentize BottomSheet #6106

merged 22 commits into from
Aug 30, 2023

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Apr 3, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

  • Renamed BottomSheetContent to BottomSheetDialog
  • Moved BottomSheetDialog and BottomSheetOverlay into foundation
  • Added BottomSheet controls

Screenshots/Recordings
Simulator Screen Shot - iPhone 14 Pro - 2023-07-24 at 21 13 24

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@brianacnguyen brianacnguyen requested a review from a team as a code owner April 3, 2023 14:50
@brianacnguyen brianacnguyen self-assigned this Apr 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @brianacnguyen, should this be rebased? I see a lot of conflicts. It would be great to update the PR description too

@Cal-L Cal-L added ready-for-dev team-design-system All issues relating to design system in Mobile needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed ready-for-dev labels Jul 25, 2023
@Cal-L
Copy link
Contributor

Cal-L commented Aug 2, 2023

Could you also resolve checks

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.05% ⚠️

Comparison is base (7fa438e) 32.83% compared to head (d6e270a) 32.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6106      +/-   ##
==========================================
- Coverage   32.83%   32.78%   -0.05%     
==========================================
  Files         998     1001       +3     
  Lines       26674    26710      +36     
  Branches     2092     2096       +4     
==========================================
  Hits         8758     8758              
- Misses      17498    17534      +36     
  Partials      418      418              
Files Changed Coverage Δ
.../BottomSheets/BottomSheet/BottomSheet.constants.ts 0.00% <0.00%> (ø)
...s/BottomSheets/BottomSheet/BottomSheet.stories.tsx 0.00% <0.00%> (ø)
...nts/BottomSheets/BottomSheet/BottomSheet.styles.ts 0.00% <0.00%> (ø)
...omponents/BottomSheets/BottomSheet/BottomSheet.tsx 0.00% <0.00%> (ø)
...n/BottomSheetDialog/BottomSheetDialog.constants.ts 0.00% <0.00%> (ø)
...tion/BottomSheetDialog/BottomSheetDialog.styles.ts 0.00% <ø> (ø)
...foundation/BottomSheetDialog/BottomSheetDialog.tsx 0.00% <0.00%> (ø)
.../BottomSheetOverlay/BottomSheetOverlay.stories.tsx 0.00% <ø> (ø)
...undation/BottomSheetOverlay/BottomSheetOverlay.tsx 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@brianacnguyen brianacnguyen merged commit 2a1a46a into main Aug 30, 2023
11 checks passed
@brianacnguyen brianacnguyen deleted the morph/componentize-bottomsheet branch August 30, 2023 19:02
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 30, 2023
@metamaskbot metamaskbot added the release-7.7.0 Issue or pull request that will be included in release 7.7.0 label Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.7.0 Issue or pull request that will be included in release 7.7.0 team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants