Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] On-ramp: Add orderProcessor exponential backoff for orders #6138

Merged
merged 6 commits into from
Apr 19, 2023

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Apr 6, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This pull request adds exponential backoff functionality to the order polling system. The backoff time will increase with each unknown order status. Additionally, users will still have the ability to force reload the order if necessary.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features release-6.4.0 PR for release 6.4.0 labels Apr 6, 2023
@wachunei wachunei requested a review from a team as a code owner April 6, 2023 13:25
Copy link
Contributor

@Fatxx Fatxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei added release-6.5.0 needs-ramp-qa Tickets that need feature QA on the ramps flows and removed release-6.4.0 PR for release 6.4.0 needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Apr 11, 2023
@bkirb
Copy link
Contributor

bkirb commented Apr 19, 2023

@wachunei I tested this branch and verified there are no regressions. I placed several orders on different chains.

@wachunei wachunei added ramp-qa-passed and removed needs-ramp-qa Tickets that need feature QA on the ramps flows labels Apr 19, 2023
@wachunei wachunei merged commit 9f97461 into main Apr 19, 2023
13 checks passed
@wachunei wachunei deleted the feature/onramp-orders-backoff branch April 19, 2023 18:03
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ramp-qa-passed release-6.5.0 team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants