Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On-ramp: Add same amount rendering as the order details to the order list #6139

Merged
merged 5 commits into from
Apr 19, 2023
Merged

On-ramp: Add same amount rendering as the order details to the order list #6139

merged 5 commits into from
Apr 19, 2023

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Apr 6, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Ensure consistent crypto number formatting across orders list and order details view.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-6.4.0 Issue or pull request that will be included in release 6.4.0 labels Apr 6, 2023
@wachunei wachunei requested a review from a team as a code owner April 6, 2023 13:37
@wachunei wachunei added release-6.5.0 Issue or pull request that will be included in release 6.5.0 and removed release-6.4.0 Issue or pull request that will be included in release 6.4.0 labels Apr 11, 2023
@wachunei wachunei requested a review from sethkfman April 14, 2023 13:54
@Cal-L
Copy link
Contributor

Cal-L commented Apr 17, 2023

Could you provide visual snapshots of the changes where this is affected?

@wachunei
Copy link
Member Author

image

These display different ETH amount, they will render the same after this change.

Cal-L
Cal-L approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 19, 2023
@wachunei wachunei merged commit 0b94b54 into main Apr 19, 2023
@wachunei wachunei deleted the refactor/onramp-list-item-amount branch April 19, 2023 16:27
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

@sethkfman sethkfman Awaiting requested review from sethkfman

Assignees
No one assigned
Labels
release-6.5.0 Issue or pull request that will be included in release 6.5.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wachunei @Cal-L @sethkfman