Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On-ramp: Refactor order selector by id #6153

Merged
merged 3 commits into from
Apr 14, 2023
Merged

On-ramp: Refactor order selector by id #6153

merged 3 commits into from
Apr 14, 2023

Conversation

wachunei
Copy link
Member

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR adds a small refactor to the order selector which was not using the reselect createSelector recommended way to make a selector take an argument.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features needs-ramp-qa Tickets that need feature QA on the ramps flows release-6.5.0 labels Apr 10, 2023
@wachunei wachunei requested a review from a team as a code owner April 10, 2023 13:02
sethkfman
sethkfman approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 10, 2023
@wachunei wachunei removed the needs-ramp-qa Tickets that need feature QA on the ramps flows label Apr 14, 2023
@wachunei wachunei merged commit 7d483f5 into main Apr 14, 2023
13 checks passed
@wachunei wachunei deleted the refactor/onramp-order-selector branch April 14, 2023 17:03
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
ramp-qa-passed release-6.5.0 team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wachunei @sethkfman