-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On-ramp: Use dynamic list of networks #6156
Conversation
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
|
13d2bb0
to
c92b642
Compare
@bkirb can you confirm this is QAd please 🙏 |
@wachunei I verified this PR and made several orders with different tokens and chains. |
@wachunei Can you resolve the conflicts on this PR? |
what conflicts? 😜 just did lol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
label when dev review is completedQA Passed
label when QA has signed offDescription
This PR adopts a dynamic list of supported networks for the on-ramp aggregator.
on-ramp-sdk
is updated to version1.12.0
, this version includesgetNetworks
methodallowedToBuy
method and hardcoded list was removeduseOnRampNetworks
hook is added, it updates the networks on the state with the result ofgetNetworks
useOnRampNetwork
hook and util functions are added to replaceallowedToBuy
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your changeIssue
Progresses #???
Checklist