Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] Change Password setting #6157

Merged
merged 5 commits into from
Apr 11, 2023
Merged

[REFACTOR] Change Password setting #6157

merged 5 commits into from
Apr 11, 2023
+77 −31

Conversation

gantunesr
Copy link
Member

Description

Refactor 'Change Password' setting to TS and extract it from the SecuritySettings file.

Screenshots/Recordings

Not applicable

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-6.5.0 labels Apr 11, 2023
@gantunesr gantunesr marked this pull request as ready for review April 11, 2023 01:42
@gantunesr gantunesr requested a review from a team as a code owner April 11, 2023 01:42
blackdevelopa
blackdevelopa approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@blackdevelopa blackdevelopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 11, 2023
@gantunesr gantunesr merged commit d382adb into main Apr 11, 2023
13 checks passed
@gantunesr gantunesr deleted the refactor/password-setting branch April 11, 2023 12:45
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Assignees
No one assigned
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-6.5.0 team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gantunesr @blackdevelopa @gauthierpetetin