feat: trigger walletconnect modal using approval controller #6166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OGPoyraz
added
needs-qa
OGPoyraz
force-pushed
the
feat/768-trigger-modal-using-approval-request-created-on-walletconnect-request
branch
from
9ac252f
to
032788b
Compare
OGPoyraz
force-pushed
the
feat/768-trigger-modal-using-approval-request-created-on-walletconnect-request
branch
6 times, most recently
from
239ff6b
to
77e7aaa
Compare
OGPoyraz
force-pushed
the
feat/768-trigger-modal-using-approval-request-created-on-walletconnect-request
branch
from
77e7aaa
to
e01fefc
Compare
cortisiko
removed
the
needs-qa
matthewwalsh0
approved these changes
Apr 20, 2023
OGPoyraz
deleted the
feat/768-trigger-modal-using-approval-request-created-on-walletconnect-request
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to make WalletConnect use
ApprovalControllerand its own accept/reject mechanism instead ofwalletconnectSessionRequestwalletconnectSessionRequest::approvedwalletconnectSessionRequest::rejected.UI flow of WalletConnect is not affected, only functional changes.
Screenshots/Recordings
Simulator.Screen.Recording.-.iPhone.12.Pro.-.2023-04-12.at.12.07.56.mp4
Issue
https://github.com/MetaMask/mobile-planning/issues/768
Checklist