Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Componentize Header Component #6181

Merged
merged 7 commits into from
Apr 14, 2023
Merged

Componentize Header Component #6181

merged 7 commits into from
Apr 14, 2023

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Apr 12, 2023 •
edited by Cal-L

Description

Componentize Header Component

Screenshots/Recordings
Simulator Screen Shot - iPhone 14 Pro - 2023-04-12 at 12 19 15

Issue
#5914

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile labels Apr 12, 2023
@brianacnguyen brianacnguyen requested a review from a team as a code owner April 12, 2023 19:14
@brianacnguyen brianacnguyen self-assigned this Apr 12, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. team-design-system and removed team-mobile-client labels Apr 12, 2023
Cal-L
Cal-L reviewed Apr 12, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

app/component-library/components/Header/README.md Outdated Show resolved Hide resolved
app/component-library/components/Header/README.md Outdated Show resolved Hide resolved
app/component-library/components/Header/Header.test.tsx Show resolved Hide resolved
app/component-library/components/Header/Header.styles.ts Outdated Show resolved Hide resolved
app/component-library/components/Header/Header.styles.ts Outdated Show resolved Hide resolved
app/component-library/components/Header/Header.styles.ts Outdated Show resolved Hide resolved
Cal-L
Cal-L approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 14, 2023
@brianacnguyen brianacnguyen merged commit dc48b08 into main Apr 14, 2023
13 checks passed
@brianacnguyen brianacnguyen deleted the morph/componentize-header branch April 14, 2023 17:33
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees

@brianacnguyen brianacnguyen

Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. team-design-system All issues relating to design system in Mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brianacnguyen @Cal-L