On-ramp:Remove hiding the provider modal when quotes refresh #6189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachunei
added
needs-dev-review
|
Can you provide a vid with the changes? - This doesn't seem like a spot check since it changes behavior. Could you confirm? |
|
Here is a video of the change: The modal used to dismiss when the quotes refresh. Now it stays present so the user can read it. |
|
@bkirb Thank you for adding context, I'll mark this as QA passed. |
wachunei
added
ramp-qa-passed
and removed
Spot Check on the Release Build
Cal-L
removed
the
needs-dev-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
This PR removes hiding the modal that shows the provider information when quotes reload in the quotes page.
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses #???
Checklist