Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] [SDK] Missing redirect breaking backward compatibility #6201

Merged
merged 6 commits into from
Apr 20, 2023
Merged

[FIX] [SDK] Missing redirect breaking backward compatibility #6201

merged 6 commits into from
Apr 20, 2023

Conversation

abretonc7s
Copy link
Contributor

Fixes #6175 .

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@abretonc7s abretonc7s marked this pull request as ready for review April 17, 2023 08:54
@abretonc7s abretonc7s requested a review from a team as a code owner April 17, 2023 08:54
@abretonc7s abretonc7s added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Apr 18, 2023
@christopherferreira9 christopherferreira9 added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 18, 2023
andreahaku
andreahaku approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreahaku andreahaku added needs-qa Any New Features that needs a full manual QA prior to being added to a release. release-6.5.0 and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Apr 18, 2023
@christopherferreira9 christopherferreira9 added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 18, 2023
@andreahaku andreahaku mentioned this pull request Apr 18, 2023
Closed
@socket-security
Copy link

socket-security bot commented Apr 18, 2023 •
edited

New dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

🚮 Removed packages: @metamask/sdk-communication-layer@0.2.0

@andreahaku andreahaku changed the title fix: missing redirect breaking backward compatibility [fix] SDK: Missing redirect breaking backward compatibility Apr 18, 2023
@andreahaku andreahaku changed the title [fix] SDK: Missing redirect breaking backward compatibility [FIX] SDK: Missing redirect breaking backward compatibility Apr 18, 2023
@andreahaku andreahaku changed the title [FIX] SDK: Missing redirect breaking backward compatibility [FIX] [SDK] Missing redirect breaking backward compatibility Apr 18, 2023
@christopherferreira9 christopherferreira9 added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed QA in Progress QA has started on the feature. labels Apr 18, 2023
@abretonc7s abretonc7s force-pushed the fix/6175-sdk-incompatibility branch 3 times, most recently from f60542b to 2edb973 Compare April 20, 2023 11:18
@christopherferreira9 christopherferreira9 added QA in Progress QA has started on the feature. and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Apr 20, 2023
@christopherferreira9
Copy link
Contributor

QA Passed

@christopherferreira9 christopherferreira9 merged commit 5979361 into main Apr 20, 2023
13 checks passed
@christopherferreira9 christopherferreira9 deleted the fix/6175-sdk-incompatibility branch April 20, 2023 13:53
@christopherferreira9 christopherferreira9 added the QA Passed A successful QA run through has been done label Apr 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2023
@christopherferreira9 christopherferreira9 removed the QA in Progress QA has started on the feature. label Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreahaku andreahaku andreahaku approved these changes

Assignees

@andreahaku andreahaku

@christopherferreira9 christopherferreira9

Labels
QA Passed A successful QA run through has been done release-6.5.0 team-sdk SDK team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0.1.0 SDK Compatibility issue
3 participants
@abretonc7s @christopherferreira9 @andreahaku