-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account Icon matches User's Preferred Identicon #6216
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving with the notion that we will move logic from ApproveTransactionHeader into the domain of AccountBalance or AccountBase in a future PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
The fix looks good. Now the Identicon is matching the selected preference from the user. This is displayed on the 2 duplicated The PR is good to merge mobile-identicon-fixed.mp4 |
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
label when dev review is completedQA Passed
label when QA has signed offDescription
The account icon should match the user's preferred identicon. See issue
Steps:
Screenshots/Recordings
Before:
After: http://recordit.co/vOtElnCTgq
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses https://github.com/MetaMask/mobile-planning/issues/894
Checklist