Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated button's icon props and button org #6226

Merged
merged 5 commits into from
Apr 21, 2023
Merged

Updated button's icon props and button org #6226

merged 5 commits into from
Apr 21, 2023

Conversation

brianacnguyen
Copy link
Contributor

Description

  • Replaced iconName with startIconName from ButtonBase
  • Added endIconName
  • Updated Button's constants, stories, readmes, types, and style to best consistent with current code practices.

Screenshots/Recordings
Simulator Screen Shot - iPhone 14 Pro - 2023-04-19 at 14 55 38
Simulator Screen Shot - iPhone 14 Pro - 2023-04-19 at 14 55 41
Simulator Screen Shot - iPhone 14 Pro - 2023-04-19 at 14 55 45
Simulator Screen Shot - iPhone 14 Pro - 2023-04-19 at 14 56 03

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile team-design-system labels Apr 19, 2023
@brianacnguyen brianacnguyen requested a review from a team as a code owner April 19, 2023 22:00
@brianacnguyen brianacnguyen self-assigned this Apr 19, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brianacnguyen brianacnguyen merged commit cc430fa into main Apr 21, 2023
13 checks passed
@brianacnguyen brianacnguyen deleted the morph/update-buttons branch April 21, 2023 16:48
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpcloureiro jpcloureiro jpcloureiro approved these changes

Assignees

@brianacnguyen brianacnguyen

Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brianacnguyen @jpcloureiro