Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Clear Privacy section #6234

Merged
merged 10 commits into from
May 15, 2023
Merged

[REFACTOR] Clear Privacy section #6234

merged 10 commits into from
May 15, 2023

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Apr 20, 2023

Description

Refactor 'Clear Privacy' setting to TS and extract it from the SecuritySettings file. The functionality should stay the same as it's today.

Screenshots/Recordings

As showed in the video, after connecting to a dapp, if the user chooses to clear the privacy data, all connections must be revoked.

Screen.Recording.2023-04-20.at.20.08.23.mov

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-client labels Apr 20, 2023
@gantunesr gantunesr marked this pull request as ready for review April 20, 2023 15:51
@gantunesr gantunesr requested a review from a team as a code owner April 20, 2023 15:51
@sethkfman
Copy link
Contributor

@gantunesr Can you show a successful E2E test run? I think the label should go to your team.

@gantunesr
Copy link
Member Author

gantunesr commented Apr 20, 2023

@sethkfman can you provide the reasons for my team's label? Just because I'm the author does not imply that the work is relevant to my team. Either way, as the author, I will personally be responsible for any bugs introduced as it should be the norm

@gantunesr
Copy link
Member Author

Regarding the E2E, I'm waiting on the dev review to solve any comment presented and then run the required workflow

@cortisiko
Copy link
Member

Hmm chiming in here, this is the right approach. The E2E tests should be triggered after a successful dev review. You should also post the bitrise build with the test run on this PR.

Regarding the E2E, I'm waiting on the dev review to solve any comment presented and then run the required workflow

@chrisleewilcox chrisleewilcox removed the No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. label Apr 23, 2023
@chrisleewilcox
Copy link
Contributor

@gantunesr I think this needs QA. Please add needs-qa label once dev review is complete.

@gantunesr
Copy link
Member Author

@chrisleewilcox I disagree with you, I have already discussed this PR with @cortisiko

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman added release-6.7.0 6.7.0 release tickets and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels May 5, 2023
@gauthierpetetin gauthierpetetin added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label May 5, 2023
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR did not require any feature QA. However, I did a light manual smoke test on the security and privacy page. I also ran the e2e tests for both android and iOS. Nothing to report.

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels May 15, 2023
@cortisiko cortisiko merged commit e204a24 into main May 15, 2023
19 checks passed
@cortisiko cortisiko deleted the refactor/clear-privacy branch May 15, 2023 20:25
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2023
@cortisiko cortisiko added release-7.1.0 and removed release-6.7.0 6.7.0 release tickets labels May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants