-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REFACTOR] Clear Privacy section #6234
Conversation
This reverts commit 8aac1e0.
@gantunesr Can you show a successful E2E test run? I think the label should go to your team. |
@sethkfman can you provide the reasons for my team's label? Just because I'm the author does not imply that the work is relevant to my team. Either way, as the author, I will personally be responsible for any bugs introduced as it should be the norm |
Regarding the E2E, I'm waiting on the dev review to solve any comment presented and then run the required workflow |
Hmm chiming in here, this is the right approach. The E2E tests should be triggered after a successful dev review. You should also post the bitrise build with the test run on this PR.
|
@gantunesr I think this needs QA. Please add |
@chrisleewilcox I disagree with you, I have already discussed this PR with @cortisiko |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR did not require any feature QA. However, I did a light manual smoke test on the security and privacy page. I also ran the e2e tests for both android and iOS. Nothing to report.
Description
Refactor 'Clear Privacy' setting to TS and extract it from the SecuritySettings file. The functionality should stay the same as it's today.
Screenshots/Recordings
As showed in the video, after connecting to a dapp, if the user chooses to clear the privacy data, all connections must be revoked.
Screen.Recording.2023-04-20.at.20.08.23.mov
Issue
Progresses #???
Checklist