Confirm button should be disabled if account has no balance #6253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
jpuri
commented
Apr 24, 2023
segun
reviewed
Apr 25, 2023
digiwand
reviewed
Apr 25, 2023
blackdevelopa
approved these changes
Apr 26, 2023
|
@jpuri @blackdevelopa can we rebase this PR off of branch |
digiwand
approved these changes
Apr 26, 2023
|
The fix looks good. I've opened 2 other issues related to that, but can be fixed in separate PRs: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression issue about confirm button being enabled even if account has no balance.
Fix is small its the first commit. More changes were needed to write test cases 2,3 commit are done for test cases.