Confirmations: Empty SiteURL and Null TagURL in modal #6274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
blackdevelopa
added
needs-dev-review
jpuri
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
Hey @blackdevelopa , changes look good. Will be nice to have some test coverage also.
segun
reviewed
Apr 27, 2023
segun
reviewed
Apr 27, 2023
app/components/UI/TransactionReview/TransactionReviewDetailsCard/index.js
Show resolved
Hide resolved
segun
previously approved these changes
May 3, 2023
blackdevelopa
added
needs-qa
|
Looks good @blackdevelopa I can see how the URL is not displayed when not available.
|
seaona
added
QA Passed
jpuri
approved these changes
May 15, 2023
segun
approved these changes
May 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
There are two issues that show up on the approve confirmation modal when you deeplink to the app. The first is a null tagURL which is well documented here and the second is an undefined Site URL value well documented here. Following the conversations on the issues and here, here, this PR includes a fix that hides both the tagurl and siteurl when not available.
Screenshots/Recordings
RPReplay_Final1682506644.MP4
Issue
Progresses #5570 and https://github.com/MetaMask/mobile-planning/issues/883
Checklist