refactor: trigger transaction modals using approval requests #6291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
vinistevam
force-pushed
the
transaction-controller-update
branch
from
add9ad8
to
d2d1d9c
Compare
vinistevam
changed the title
bergarces
reviewed
May 25, 2023
bergarces
reviewed
May 25, 2023
bergarces
reviewed
May 25, 2023
bergarces
reviewed
May 25, 2023
bergarces
reviewed
May 25, 2023
bergarces
reviewed
May 25, 2023
vinistevam
changed the title
vinistevam
force-pushed
the
transaction-controller-update
branch
from
363b71c
to
cd725ad
Compare
vinistevam
changed the title
vinistevam
force-pushed
the
transaction-controller-update
branch
from
cd725ad
to
3e7b5e9
Compare
bergarces
reviewed
May 30, 2023
vinistevam
force-pushed
the
transaction-controller-update
branch
from
171b8bb
to
94c25ed
Compare
matthewwalsh0
approved these changes
Jun 6, 2023
bergarces
approved these changes
Jun 8, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
This PR applies a change to TransactionController that has already been merged in the core repo. Unfortunately, there are breaking changes blocking the ability to upgrade the package directly.
The changes from the core PR for visibility. It implies that confirmations for transaction requests will no longer be handled by an event, but sent directly to ApprovalController. This is part of the work to standardise and simplify how confirmations work across extension and mobile.
Screenshots/Recordings
Transaction tests
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
resolves: https://github.com/MetaMask/mobile-planning/issues/770
Checklist