feat: [MC 0.5] - Activity view and Settings on the tab bar #6294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
tommasini
added
needs-dev-review
gauthierpetetin
added
in-progress
needs-dev-review
|
@NicolasMassart Thanks for the review!! Do you remember the network you were in? I think this was already happening, I will take a look |
I was on goerli testnet |
|
@NicolasMassart I can't reproduce it :/ https://recordit.co/KjHww2kAoa |
Cal-L
added
needs-qa
… param to false on network selector when navigate to network list on settings
… to be reached for a better ux
Cal-L
reviewed
May 25, 2023
app/components/Views/Settings/NetworksSettings/NetworkSettings/index.js
Outdated
Show resolved
Hide resolved
…network. Clean code. Solve Bug when exist custom rpc url
Cal-L
reviewed
May 25, 2023
* Update Test scripts to new Settings tab bar button * Fix return to wallet view screen step * Remove extra steps * Update cucumber tag for android local config files * Update test steps
* Update Test scripts to new Settings tab bar button * Fix return to wallet view screen step * Remove extra steps * Update detox test * Change add custom network test id and update affected files * Fix eslint errors
tommasini
changed the title
SamuelSalas
added
QA Passed
|
Kudos, SonarCloud Quality Gate passed! |
gauthierpetetin
added
the
team-mobile-ux
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to move the activity view and settings from the drawer view to the bottom tab bar.
Screenshots/Recordings
Scenario: Activity should be a new action that's added to the Tab bar:
Scenario: Settings should be a new action that's added to the Tab bar:
Scenario: Settings screen should show when the Settings tab item is selected: https://recordit.co/esSIk6jVv0
Scenario: Activity screen should show when the Activity tab item is selected: https://recordit.co/RaYkls6qBb
Scenario: Activity and Settings options should be removed from the Drawer
Scenario: Navigate to settings from the tab bar always navigate to Settings view: http://recordit.co/p7ZhSi2bsO
Scenario: Add network, when pressed goes back it always returns to the last screen: https://recordit.co/I1f77adphV
Scenario: Add Custom rpc for ethereum mainnet: https://recordit.co/5DHZTlD7sP
Issue
Progresses #???
Checklist