Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On-ramp: add development environment to on-ramp-sdk #6325

Merged
merged 2 commits into from
May 4, 2023
Merged

On-ramp: add development environment to on-ramp-sdk #6325

merged 2 commits into from
May 4, 2023

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented May 3, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR assigns the on-ramp-sdk environment correctly according to the mobile build and ONRAMP_INTERNAL_BUILD environment variable:

Mobile build ONRAMP_INTERNAL_BUILD ➡️ On-ramp SDK Environment
Development / Testing false Development
Development / Testing true Staging
Production true Staging
Production false Production

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei added next release No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features labels May 3, 2023
@wachunei wachunei requested a review from a team as a code owner May 3, 2023 17:00
@wachunei wachunei changed the title : add development environment to on-ramp-sdk On-ramp: add development environment to on-ramp-sdk May 3, 2023
Cal-L
Cal-L approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei force-pushed the feature/onramp-sdk-dev-env branch from 45e02a8 to f1b4914 Compare May 4, 2023 12:08
@wachunei wachunei added release-6.6.0 PR for release 6.6.0 and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) next release labels May 4, 2023
@wachunei wachunei merged commit bf454e1 into main May 4, 2023
13 checks passed
@wachunei wachunei deleted the feature/onramp-sdk-dev-env branch May 4, 2023 20:33
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-6.6.0 PR for release 6.6.0 team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wachunei @Cal-L