-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(devDeps): bump webdriverio packages #6328
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Ignoring: Pull request alert summary
📊 Modified Dependency Overview:
🚮 Removed packages: wdio-chromedriver-service@7.3.2, wdio-cucumber-reporter@0.0.2, wdio-image-comparison-service@3.1.1, wdio-vscode-service@0.1.13 |
These can be addressed in v8 upgrade |
741b96d
to
c201a4e
Compare
@cortisiko after we complete the RN upgrade we should look at this |
Why not the other direction? If anything, I'd see this one as a precursor. |
c201a4e
to
10a0665
Compare
@SocketSecurity ignore @wdio/browserstack-service@7.31.1 |
10a0665
to
53d4f5f
Compare
Maintenance update staying on major version v7. Upgrading to current [v8](https://github.com/webdriverio/webdriverio/releases/tag/v8.0.0) addressed in a later change.
Subdeps of wdio framework
Unmaintained since 2016 and does not seem to work with currently used version of webdriverio anyway. Drops transitive dependency on deprecated babel-runtime v5.
Removes transitive dep on @mapbox/node-pre-gyp
53d4f5f
to
97d3e46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any adv explicitly tracking @cucumber/message-streams
?
alrdy in wdio-related peer deps
├── @cucumber/message-streams@4.0.1
├─┬ @wdio/cucumber-framework@7.31.1
│ ├─┬ @cucumber/cucumber@8.6.0
│ │ ├─┬ @cucumber/gherkin-streams@5.0.1
│ │ │ └── @cucumber/message-streams@4.0.1 deduped
│ │ └── @cucumber/message-streams@4.0.1 deduped
│ └─┬ @cucumber/gherkin-streams@5.0.1
│ └── @cucumber/message-streams@4.0.1 deduped
└─┬ wdio-cucumberjs-json-reporter@4.4.3
└─┬ @cucumber/gherkin@22.0.0
└── @cucumber/message-streams@3.0.0
(same for @cucumber/messages
)
├─┬ @cucumber/message-streams@4.0.1
│ └── @cucumber/messages@22.0.0 deduped
├── @cucumber/messages@22.0.0
├─┬ @wdio/cucumber-framework@7.31.1
│ ├─┬ @cucumber/cucumber@8.6.0
│ │ ├─┬ @cucumber/gherkin-streams@5.0.1
│ │ │ ├─┬ @cucumber/gherkin@26.0.3
│ │ │ │ └── @cucumber/messages@21.0.1 deduped
│ │ │ └── @cucumber/messages@21.0.1
│ │ ├─┬ @cucumber/gherkin-utils@8.0.0
│ │ │ └── @cucumber/messages@19.1.4
│ │ ├─┬ @cucumber/gherkin@24.0.0
│ │ │ └── @cucumber/messages@19.1.4
│ │ ├─┬ @cucumber/html-formatter@20.0.0
│ │ │ └── @cucumber/messages@19.1.2 deduped
│ │ └── @cucumber/messages@19.1.2
│ ├─┬ @cucumber/gherkin-streams@5.0.1
│ │ └── @cucumber/messages@21.0.1 deduped
│ ├─┬ @cucumber/gherkin@26.0.3
│ │ └── @cucumber/messages@21.0.1
│ └── @cucumber/messages@21.0.1
├─┬ prettier-plugin-gherkin@1.1.1
│ ├─┬ @cucumber/gherkin@24.1.0
│ │ └── @cucumber/messages@19.1.4 deduped
│ └── @cucumber/messages@19.1.4
└─┬ wdio-cucumberjs-json-reporter@4.4.3
└─┬ @cucumber/gherkin@22.0.0
├─┬ @cucumber/message-streams@3.0.0
│ └── @cucumber/messages@17.1.1 deduped
└── @cucumber/messages@17.1.1
otherwise thx and lgtm!
@leotm added them after yarn was complaining so assumed the expected thing would be to add them. Thanks for the thoughtful review. |
Description
wdio-cucumberjs-json-reporter
should be separately be upgraded to v5 together with cucumberjs and wdio peerDeps: https://github.com/webdriverio-community/wdio-cucumberjs-json-reporter/pull/117/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519wdio-chromedriver-service
,wdio-cucumber-reporter
,wdio-image-comparison-service
,wdio-vscode-service
@cucumber/message-streams
,@cucumber/messages
Checklist