Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Aurora Token Detection #6334

Merged
merged 4 commits into from
May 25, 2023
Merged

Add Aurora Token Detection #6334

merged 4 commits into from
May 25, 2023

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented May 4, 2023 •
edited

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR enables Aurora Token detection by patching the changes from MetaMask/core#1327

Screenshots/Recordings
Token is being autodetected:

QA Steps
Use any wallet with aurora tokens (like orangefox.eth) and tokens must be autodetected when token detection is on

Issue

Progresses #5037

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei force-pushed the feature/aurora-token-detection branch from a359b1e to dc3b30f Compare May 4, 2023 13:26
@wachunei wachunei added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-6.6.0 PR for release 6.6.0 labels May 4, 2023
@wachunei wachunei marked this pull request as ready for review May 4, 2023 13:28
@wachunei wachunei requested a review from a team as a code owner May 4, 2023 13:28
Cal-L
Cal-L previously approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Cal-L Cal-L removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 4, 2023
@sethkfman
Copy link
Contributor

@wachunei Who is doing the QA on this ticket?

@wachunei
Copy link
Member Author

wachunei commented May 8, 2023

@wachunei Who is doing the QA on this ticket?

@sethkfman I don't know who will take it

@wachunei wachunei force-pushed the feature/aurora-token-detection branch from dc3b30f to 523c54f Compare May 8, 2023 12:05
@wachunei wachunei force-pushed the feature/aurora-token-detection branch from 523c54f to 0e4b8e6 Compare May 15, 2023 14:31
@wachunei wachunei force-pushed the feature/aurora-token-detection branch from 0e4b8e6 to ba437f4 Compare May 15, 2023 14:32
mcmire
mcmire approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch makes sense!

@wachunei wachunei added release-6.7.0 6.7.0 release tickets release-7.1.0 and removed release-6.6.0 PR for release 6.6.0 release-6.7.0 6.7.0 release tickets labels May 18, 2023
@bkirb
Copy link
Contributor

bkirb commented May 25, 2023 •
edited

Screenshot 2023-05-25 at 3 55 08 PM

LGTM I verified the auto detection changes

@wachunei wachunei added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels May 25, 2023
@wachunei wachunei merged commit a6a5d35 into main May 25, 2023
12 checks passed
@wachunei wachunei deleted the feature/aurora-token-detection branch May 25, 2023 22:56
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcmire mcmire mcmire approved these changes

@Cal-L Cal-L Cal-L left review comments

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-7.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wachunei @sethkfman @bkirb @mcmire @Cal-L