Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yarn watch clean #6339

Merged
merged 2 commits into from
May 5, 2023
Merged

Fix yarn watch clean #6339

merged 2 commits into from
May 5, 2023

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented May 4, 2023

Description

When using yarn watch:clean, we use the --reset-cache argument and also delete the $TMPDIR/react-* directories in an attempt to ensure all source files are compiled from scratch when building.

Despite this, files continue to be cached, and so this PR instead deletes the $TMPDIR/metro-cache directory where the React native cache is now stored.

Steps To Demonstrate Error

  1. Provide an expired Infura project ID in .js.env.
  2. yarn setup
  3. yarn watch:clean
  4. yarn start:ios
  5. See expected block polling errors.
  6. Provide a valid Infura project ID in .js.env.
  7. yarn watch:clean
  8. yarn start:ios
  9. Continue to see expected block polling errors given the compiled Engine.ts including the env is cached.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@matthewwalsh0 matthewwalsh0 changed the title Delete metro cache directory when performing watch clean Fix yarn watch clean May 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review May 5, 2023 08:50
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner May 5, 2023 08:50
@matthewwalsh0 matthewwalsh0 merged commit 82ebe72 into main May 5, 2023
@matthewwalsh0 matthewwalsh0 deleted the chore/fix-watch-clean branch May 5, 2023 09:59
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants