Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-ramp: fix missing network name #6340

Merged
merged 1 commit into from
May 4, 2023
Merged

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented May 4, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR fixes a translation error being shown when the network name was not available.

Screenshots/Recordings
Before - After

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-6.6.0 PR for release 6.6.0 labels May 4, 2023
@wachunei wachunei requested a review from a team as a code owner May 4, 2023 16:40
@wachunei wachunei force-pushed the fix/onramp-missing-network-name branch from 4e9916a to 3e1f6b7 Compare May 4, 2023 16:45
@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 4, 2023
@wachunei wachunei merged commit 360f8b7 into main May 4, 2023
13 checks passed
@wachunei wachunei deleted the fix/onramp-missing-network-name branch May 4, 2023 22:24
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-6.6.0 PR for release 6.6.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants