Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update es.js file #6345

Merged
merged 2 commits into from
May 5, 2023
Merged

Update es.js file #6345

merged 2 commits into from
May 5, 2023

Conversation

Unik0rnMaggie
Copy link
Contributor

Hi Team,

We have noticed some mistakes in the ES translation for MM mobile:

  • "Nonce" should be translated as "Nonce", instead of "mientras tanto" (which means "meanwhile"), as it currently is now.
  • "Agilizar" should be replaced with "Acelerar", for consistency: everywhere else, "speed up" was translated as "Acelerar"

Thank you!

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Hi Team,

We have noticed some mistakes in the ES translation for MM mobile:

 - "Nonce" should be translated as "Nonce", instead of "mientras tanto" (which means "meanwhile"), as it currently is now. 
- "Agilizar" should be replaced with "Acelerar", for consistency: everywhere else, "speed up" was translated as "Acelerar"

Thank you!
@Unik0rnMaggie Unik0rnMaggie requested a review from a team as a code owner May 5, 2023 09:59
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Unik0rnMaggie
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman added the release-6.7.0 6.7.0 release tickets label May 5, 2023
@sethkfman sethkfman merged commit 14bc696 into MetaMask:main May 5, 2023
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2023
@Unik0rnMaggie Unik0rnMaggie deleted the patch-1 branch May 8, 2023 08:11
@cortisiko cortisiko added release-7.1.0 and removed release-6.7.0 6.7.0 release tickets labels May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants