Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update en.json with eth_sign #6374

Merged
merged 3 commits into from
May 15, 2023
Merged

Update en.json with eth_sign #6374

merged 3 commits into from
May 15, 2023

Conversation

hesterbruikman
Copy link
Contributor

Copy for #918

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Added copy for eth_sign friction https://github.com/MetaMask/mobile-planning/issues/918

Screenshots/Recordings
NA

Issue

Progresses # https://github.com/MetaMask/mobile-planning/issues/918

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@hesterbruikman hesterbruikman requested a review from a team as a code owner May 12, 2023 06:08
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@hesterbruikman
Copy link
Contributor Author

@NicolasMassart could you review please? If merged today it can go in the translation batch of Monday.

NicolasMassart
NicolasMassart approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if you add the button labels (see suggestions)

locales/languages/en.json Show resolved Hide resolved
hesterbruikman and others added 2 commits May 15, 2023 11:46
@hesterbruikman @NicolasMassart
Update locales/languages/en.json
e3fed41 
Co-authored-by: Nicolas MASSART <NicolasMassart@users.noreply.github.com>
@hesterbruikman
Merge branch 'main' into hesterbruikman-patch-1
2cabee7
@hesterbruikman hesterbruikman merged commit 8987d60 into main May 15, 2023
13 checks passed
@hesterbruikman hesterbruikman deleted the hesterbruikman-patch-1 branch May 15, 2023 11:01
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2023
@sethkfman sethkfman added the No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. label May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NicolasMassart NicolasMassart NicolasMassart approved these changes

Assignees
No one assigned
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hesterbruikman @NicolasMassart @sethkfman