-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On-ramp: add params validation to useSDKMethod hook #6381
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachunei
added
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
team-ramp
issues related to Ramp features
needs-ramp-qa
Tickets that need feature QA on the ramps flows
release-6.7.0
6.7.0 release tickets
labels
May 12, 2023
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request Pull request alert summary
|
jgmontoya
previously approved these changes
May 12, 2023
wachunei
force-pushed
the
feature/onramp-sdk-use-method-signature
branch
from
May 12, 2023 18:51
b04996d
to
af2ff5a
Compare
gantunesr
approved these changes
May 23, 2023
wachunei
removed
the
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
label
May 24, 2023
Kudos, SonarCloud Quality Gate passed! |
I verified the buying flow on this branch |
wachunei
removed
the
needs-ramp-qa
Tickets that need feature QA on the ramps flows
label
May 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
label when dev review is completedQA Passed
label when QA has signed offDescription
This PR uses upgrades the
on-ramp-sdk
to v1.20.0 and uses the newSDK.getSignature
method to retrieve an array that indicates if each parameter of a method is required or optional.This allows to enforce required parameters to not be
null
orundefined
. In case a required parameter is not valid, the method call will not happen.QA Steps
Buy flow should be completed without any changes compared to previous version
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your changeIssue
Progresses #???
Checklist