-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): upgrade ruby to 3.0.0 #6393
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Pending QA E2E build: https://app.bitrise.io/build/2befc39b-f2f3-43eb-8543-afe1d84da751 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just spotted the files introduced later in RN 0.67+ (nb: our 0.66.5)
https://github.com/facebook/react-native/blob/0.67-stable/template/Gemfile
https://github.com/facebook/react-native/blob/0.67-stable/template/_ruby-version
along with the Gem lockfile we didn't include
https://github.com/facebook/react-native/blob/0.67-stable/template/Gemfile.lock
presuming we're introducing these ahead for added security?
to prevent unmaintained Ruby v2.7 (EOL 31 Mar 2023) usage
edit: yeah makes sense, remembering now spotting the warning few mo ago
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
label when dev review is completedQA Passed
label when QA has signed offDescription
This PR adds a ruby-version and Gemfile that enforces minimum versions of Ruby and cocoa pods.
Versions are set to:
Successful QA build: https://app.bitrise.io/build/39b514f5-4579-4e7a-bcbe-03945bc4860f
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses #???
Checklist