Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): upgrade ruby to 3.0.0 #6393

Merged
merged 5 commits into from
May 16, 2023
Merged

feat(ci): upgrade ruby to 3.0.0 #6393

merged 5 commits into from
May 16, 2023

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented May 15, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR adds a ruby-version and Gemfile that enforces minimum versions of Ruby and cocoa pods.
Versions are set to:

  • Ruby Version: 3.0.0
  • Cocoapods Version: 1.12.1

Successful QA build: https://app.bitrise.io/build/39b514f5-4579-4e7a-bcbe-03945bc4860f

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. labels May 15, 2023
@sethkfman sethkfman marked this pull request as ready for review May 15, 2023 23:14
@sethkfman sethkfman requested a review from a team as a code owner May 15, 2023 23:14
@sethkfman
Copy link
Contributor Author

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 16, 2023
Copy link
Contributor

@leotm leotm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just spotted the files introduced later in RN 0.67+ (nb: our 0.66.5)
https://github.com/facebook/react-native/blob/0.67-stable/template/Gemfile
https://github.com/facebook/react-native/blob/0.67-stable/template/_ruby-version
along with the Gem lockfile we didn't include
https://github.com/facebook/react-native/blob/0.67-stable/template/Gemfile.lock

presuming we're introducing these ahead for added security?
to prevent unmaintained Ruby v2.7 (EOL 31 Mar 2023) usage

edit: yeah makes sense, remembering now spotting the warning few mo ago

@sethkfman sethkfman merged commit e5a8203 into main May 16, 2023
13 checks passed
@sethkfman sethkfman deleted the upgrade/ruby-3.0.0 branch May 16, 2023 22:17
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants