Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): Configure SonarCloud Analysis on CI #6432

Merged
merged 22 commits into from
May 23, 2023
Merged

feat(ci): Configure SonarCloud Analysis on CI #6432

merged 22 commits into from
May 23, 2023

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented May 18, 2023 •
edited

Description

This PR updates the SonarCloud analysis to be run after the unit tests complete for PR analysis. You can see the successful SonarCloud run and results in the body of this PR.

Further configuration will be needed because we haven't had a successful run on main.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman changed the title feat(ci): Setup SonarCloud Analysis on CI feat(ci): Configure SonarCloud Analysis on CI May 19, 2023
@sethkfman sethkfman added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 19, 2023
@sethkfman sethkfman marked this pull request as ready for review May 19, 2023 20:33
@sethkfman sethkfman requested a review from a team as a code owner May 19, 2023 20:33
rickycodes
rickycodes reviewed May 20, 2023
View reviewed changes
Copy link
Member

@rickycodes rickycodes left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some initial feedback based on my assumptions so forgive my ignorance if i am not following things correctly

sonar-project.properties Show resolved Hide resolved
sonar-project.properties Outdated Show resolved Hide resolved
@rickycodes rickycodes self-requested a review May 20, 2023 19:44
@sonarcloud
Copy link

sonarcloud bot commented May 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sethkfman sethkfman merged commit ea85f61 into main May 23, 2023
12 checks passed
@sethkfman sethkfman deleted the update/sonar-configs branch May 23, 2023 22:41
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rickycodes rickycodes rickycodes approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sethkfman @rickycodes