Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove invalid accessibilityRole value #6439

Merged
merged 1 commit into from
May 19, 2023

Conversation

jpcloureiro
Copy link
Contributor

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

App is crashing because of an invalid accessibilityRole value used for testing purposes.

Replace it with testID

Screenshots/Recordings

image

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@jpcloureiro jpcloureiro added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels May 19, 2023
@jpcloureiro jpcloureiro self-assigned this May 19, 2023
@jpcloureiro jpcloureiro marked this pull request as ready for review May 19, 2023 15:55
@jpcloureiro jpcloureiro requested a review from a team as a code owner May 19, 2023 15:55
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpcloureiro jpcloureiro merged commit 1b2c2ec into main May 19, 2023
12 checks passed
@jpcloureiro jpcloureiro deleted the fix/android-navbar-crash branch May 19, 2023 16:28
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed/E2E Only Apply this label when your PR does not need any QA effort.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants