[MC 0.5] - Add Account management actions #6452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew account, import an existing one being hardware or not
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
tommasini
changed the title
tommasini
added
team-mobile-client
needs-dev-review
gauthierpetetin
added
in-progress
and removed
needs-dev-review
gauthierpetetin
added
needs-dev-review
Cal-L
reviewed
May 25, 2023
app/components/Views/AccountConnect/AccountConnectMultiSelector/AccountConnectMultiSelector.tsx
Outdated
Show resolved
Hide resolved
app/components/Views/AddAccountActions/AddAccountActions.styles.ts
Outdated
Show resolved
Hide resolved
gauthierpetetin
added
needs-qa
SamuelSalas
added
QA in Progress
* Update the account list modal add accounts button * Update create and import account gherkin step * Update the account list modal add accounts button * Added the account list add button
* Update the account list modal add accounts button * Update create and import account gherkin step * Update permission system test to current account management changes
SamuelSalas
added
QA Passed
|
SonarCloud Quality Gate failed. |
gauthierpetetin
added
the
team-mobile-ux
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add a new sheet for account management actions, such as adding an account, importing an account or adding a hardware wallet.
Screenshots/Recordings
Full behaviour: https://recordit.co/rxG9CBO0E4 (The button when connected to a dapp was updated to a link button after this was recorded, all the recorders on the test cases are with the last version)
Test cases:
Scenario: The account import/creation button should exist on the account selector sheet when accessed from the Wallet view
https://recordit.co/SL47lzhYSP
Scenario: The account import/creation button should exist on the account selector sheet when accessed from the Browser view while connected to a Dapp
https://recordit.co/fAEd7ua2li
Scenario: The account import/creation button should exist on the account selector sheet when accessed from the Browser view before connecting to a Dapp
https://recordit.co/fAEd7ua2li (Last 15 seconds)
Scenario: The account import/creation button should exist on the account selector sheet when accessed from the Browser view
repeated: https://recordit.co/fAEd7ua2li
Scenario: New account should be created when Add new account is tapped from the account additions sheet
Both recordings above show this scenario
Scenario: The account should be imported when the Import account is tapped from the account additions sheet
https://recordit.co/zGUJhG7oPe
Scenario: Hardware wallet should be connected when Add hardware wallet is tapped from the account additions sheet
Needs to be tested with someone who has a hardware wallet
Issue
Progresses #???
Checklist