Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix for swaps button displaying on unsupported networks #6473

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

nikoferro
Copy link
Member

Description

This PR fixes the swap button displaying on networks that are not actually supported by swaps

Issue

Progresses #6472

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@nikoferro nikoferro requested a review from a team as a code owner May 26, 2023 13:47
@chrisleewilcox chrisleewilcox added needs-qa Any New Features that needs a full manual QA prior to being added to a release. swaps MetaSwaps issues team-mobile-client labels May 26, 2023
Copy link
Contributor

@leotm leotm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ^ swap button no longer shown on unsupported networks (screenshot)
and still shown on supported networks

@davibroc davibroc added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jun 6, 2023
@davibroc
Copy link
Contributor

davibroc commented Jun 6, 2023

I have tested the fix and the issue is no longer reproducing

@cortisiko cortisiko merged commit bd283e2 into main Jun 7, 2023
16 checks passed
@cortisiko cortisiko deleted the bugfix/6472 branch June 7, 2023 18:05
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done swaps MetaSwaps issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants