feat: [MC 0.75] Show test network toggle #6489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommasini
added
needs-dev-review
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
gauthierpetetin
added
in-progress
needs-dev-review
gauthierpetetin
added
sprint-backlog
in-progress
and removed
needs-dev-review
tommasini
added
needs-dev-review
Cal-L
reviewed
Jun 8, 2023
Cal-L
reviewed
Jun 8, 2023
Cal-L
added
needs-qa
SamuelSalas
added
QA in Progress
… toggle (#6719) * Added NetworkSelector's switch to Appium and Detox test cases * Update browser url assertion to containing * Appium and detox test scripts added for the connect to test network scenario * Add assertion that test network is not displayed after toggle off the test network switch
SamuelSalas
added
QA Passed
|
Kudos, SonarCloud Quality Gate passed! |
NicolasMassart
approved these changes
Jun 29, 2023
gauthierpetetin
added
the
team-mobile-ux
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of test network toggle on Network Selector component and persist the value on redux
Screenshots/Recordings
scenario: Open the app, activate the test network, close it, open it, it should show the test networks: https://recordit.co/yH4xwUKVPv
scenario: Open the app, deactivate the test network, close it, open it, it should not show the test networks: https://recordit.co/OyrEYWCPgO
scenario: Toggle should be on and disabled whenever a testnet is selected:
https://recordit.co/JMNzBaV75M
Core pull request
MetaMask/core#1418
Issue
Progresses #???
Checklist