Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Componentize BottomSheetFooter #6514

Merged
merged 3 commits into from
Jun 1, 2023
Merged

feat: Componentize BottomSheetFooter #6514

merged 3 commits into from
Jun 1, 2023

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Jun 1, 2023 •
edited

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Screenshots/Recordings
Simulator Screen Shot - iPhone 14 Pro - 2023-06-01 at 10 23 42
Simulator Screen Shot - iPhone 14 Pro - 2023-06-01 at 10 23 47

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile team-design-system labels Jun 1, 2023
@brianacnguyen brianacnguyen requested a review from a team as a code owner June 1, 2023 17:16
@brianacnguyen brianacnguyen self-assigned this Jun 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brianacnguyen brianacnguyen changed the title Componentize BottomSheetFooter component Componentize BottomSheetFooter Jun 1, 2023
owencraston
owencraston previously approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@owencraston owencraston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@brianacnguyen brianacnguyen changed the title Componentize BottomSheetFooter feat: Componentize BottomSheetFooter Jun 1, 2023
@brianacnguyen
Merge branch 'main' of https://github.com/MetaMask/metamask-mobile in…
657f391 
…to morph/componentize-bottomsheet-footer
@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

81.6% 81.6% Coverage
0.0% 0.0% Duplication

@brianacnguyen brianacnguyen merged commit 874f76c into main Jun 1, 2023
11 checks passed
@brianacnguyen brianacnguyen deleted the morph/componentize-bottomsheet-footer branch June 1, 2023 18:51
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@owencraston owencraston owencraston approved these changes

Assignees

@brianacnguyen brianacnguyen

Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brianacnguyen @owencraston