Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve variable naming #6520

Merged
merged 1 commit into from
Jun 15, 2023
Merged

chore: improve variable naming #6520

merged 1 commit into from
Jun 15, 2023

Conversation

blackdevelopa
Copy link
Contributor

@blackdevelopa blackdevelopa commented Jun 2, 2023 •
edited

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description
This PR implements no change to the user flow. It simply tries to improve a couple variable naming.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@blackdevelopa blackdevelopa requested a review from a team as a code owner June 2, 2023 09:57
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa added team-confirmations-secure-ux-PR PR from the confirmations team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jun 2, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@blackdevelopa blackdevelopa self-assigned this Jun 14, 2023
@blackdevelopa blackdevelopa added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jun 14, 2023
@seaona seaona removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jun 15, 2023
@seaona
Copy link
Contributor

seaona commented Jun 15, 2023

Looks like the behavior is preserved as expected @blackdevelopa . I proceed to merge the PR

@seaona seaona added QA Passed A successful QA run through has been done release-7.2.0 labels Jun 15, 2023
@seaona seaona merged commit 2f132ea into main Jun 15, 2023
20 checks passed
@seaona seaona deleted the chore/178 branch June 15, 2023 09:42
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@segun segun segun approved these changes

@NiranjanaBinoy NiranjanaBinoy NiranjanaBinoy approved these changes

Assignees

@blackdevelopa blackdevelopa

Labels
QA Passed A successful QA run through has been done release-7.2.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@blackdevelopa @seaona @segun @NiranjanaBinoy