Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Network logo to represent first letter of network #6523

Merged
merged 2 commits into from
Jun 9, 2023
Merged

fix: Network logo to represent first letter of network #6523

merged 2 commits into from
Jun 9, 2023

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Jun 2, 2023 •
edited

Description
Tokens now have the first letter of the custom Network

Screenshots/Recordings
https://recordit.co/AbZ5MJUuMB

Fallback when no internet
I think it was a development bug (pool block error) on the first seconds of the record. Because when we do not have the connection on the wallet now I just can reproduce this screen:
image

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-client labels Jun 2, 2023
@tommasini tommasini requested a review from a team as a code owner June 2, 2023 17:59
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

wachunei
wachunei previously approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@wachunei wachunei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@tommasini tommasini added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jun 7, 2023
@hesterbruikman hesterbruikman added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking labels Jun 8, 2023
@gauthierpetetin gauthierpetetin added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jun 8, 2023
chrisleewilcox
chrisleewilcox approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisleewilcox chrisleewilcox merged commit e03a1fa into main Jun 9, 2023
20 checks passed
@chrisleewilcox chrisleewilcox deleted the fix/network-logo-on-token branch June 9, 2023 19:32
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2023
@chrisleewilcox chrisleewilcox added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jun 9, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wachunei wachunei wachunei approved these changes

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

Assignees
No one assigned
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. QA Passed A successful QA run through has been done release-7.2.0 team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tommasini @wachunei @chrisleewilcox @gauthierpetetin @hesterbruikman