Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix header artifact when transitioning to Import screens #6560

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Jun 7, 2023

Description

This fix addresses an artifact that shows when navigating to both Import tokens and Import NFT screens. This same header is used when navigating to the Asset screen as well, which is responsible for the header gradient animation.

Screenshots/Recordings

This video shows a smooth transition to both the Import screen and Asset screen. It also shows that the gradient animation still works while scrolling on the Asset screen.

header.mov

@Cal-L Cal-L requested a review from a team as a code owner June 7, 2023 23:52
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-7.1.0 team-mobile-client type-bug Something isn't working needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jun 7, 2023
@gauthierpetetin gauthierpetetin added ready-for-dev and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jun 7, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Cal-L Cal-L merged commit 7822531 into main Jun 8, 2023
21 checks passed
@Cal-L Cal-L deleted the fix/asset-header-background-color branch June 8, 2023 20:30
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.2.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead type-bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants