Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Action:Transaction: remove unused prepareFullTransaction Fn #6597

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

digiwand
Copy link
Contributor

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

It doesn't look like prepareFullTransaction is used anywhere. It should be safe to remove.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@digiwand digiwand requested a review from a team as a code owner June 13, 2023 22:48
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@digiwand digiwand changed the title Action:Transaction: remove unused prepareFullTransaction Fn refactor: Action:Transaction: remove unused prepareFullTransaction Fn Jun 13, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@digiwand digiwand added the team-confirmations-secure-ux-PR PR from the confirmations team label Jun 14, 2023
@digiwand digiwand merged commit 59aa2ae into main Jun 14, 2023
13 of 14 checks passed
@digiwand digiwand deleted the action-rm-unused-prepareFullTransaction branch June 14, 2023 19:18
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants