refactor: accept SignController approval request from frontend #6600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OGPoyraz
force-pushed
the
signature-controller-promise-refactor
branch
3 times, most recently
from
79b1257
to
84a9c28
Compare
OGPoyraz
changed the title
OGPoyraz
force-pushed
the
signature-controller-promise-refactor
branch
7 times, most recently
from
b628517
to
48cbc40
Compare
OGPoyraz
force-pushed
the
signature-controller-promise-refactor
branch
9 times, most recently
from
97526ce
to
75f2eed
Compare
vinistevam
force-pushed
the
signature-controller-promise-refactor
branch
from
e1469a8
to
591b3e2
Compare
|
Kudos, SonarCloud Quality Gate passed! |
matthewwalsh0
approved these changes
Jul 25, 2023
vinistevam
approved these changes
Jul 25, 2023
vinistevam
added
team-confirmations-system
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
This PR aims to remove the
signandcancelmethods usage fromSignatureControllerand use promisified middlewares namednewUnsignedXMessagemethods.Patched PR detail could be seen here: MetaMask/core#1377 (It's merged now)
Manual Testing Steps
Recordings
sign_msgs_tests.webm
Bitrise E2E pipeline
https://app.bitrise.io/build/30379484-ceba-4d17-b1a1-97552d5fac68
(pr_smoke_e2e_pipeline) https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/16a00d66-5006-4204-b682-1337eb051e49
July 20th - https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8969daf3-08ee-4e71-8990-2dc5f5ce2eeb
Issue
https://github.com/MetaMask/mobile-planning/issues/885
Checklist