Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update Overlay and add BottomSheetOverlay #6617

Merged
merged 3 commits into from
Jun 29, 2023
Merged

feat: Update Overlay and add BottomSheetOverlay #6617

merged 3 commits into from
Jun 29, 2023

Conversation

brianacnguyen
Copy link
Contributor

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

  • Update Overlay to use different animation
  • Added BottomSheetOverlay

Screenshots/Recordings
Simulator Screen Shot - iPhone 14 Pro - 2023-06-15 at 11 00 32

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@brianacnguyen brianacnguyen added team-design-system All issues relating to design system in Mobile team-design-system labels Jun 15, 2023
@brianacnguyen brianacnguyen requested a review from a team as a code owner June 15, 2023 18:06
@brianacnguyen brianacnguyen self-assigned this Jun 15, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brianacnguyen brianacnguyen changed the title feat: Update Overlay and adde BottomSheetOverlay feat: Update Overlay and add BottomSheetOverlay Jun 15, 2023
@brianacnguyen brianacnguyen added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 15, 2023
Cal-L
Cal-L approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 29, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@brianacnguyen brianacnguyen merged commit a3a0126 into main Jun 29, 2023
12 checks passed
@brianacnguyen brianacnguyen deleted the morph/componentize-bottomsheet-overlay branch June 29, 2023 18:47
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees

@brianacnguyen brianacnguyen

Labels
release-7.3.0 team-design-system All issues relating to design system in Mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brianacnguyen @Cal-L @metamaskbot