Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix upgrade logout error on 7.1.0 #6627

Merged
merged 4 commits into from
Jun 19, 2023

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Jun 16, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR added an if check and return to the migrations added in the 7.1.0 release. It addresses the issue where the user is logged out when they upgrade.

Screenshots/Recordings

https://recordit.co/wbGYPf1u0U

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman changed the base branch from main to release/7.1.0 June 16, 2023 20:52
@sethkfman sethkfman added regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jun 16, 2023
@sethkfman sethkfman marked this pull request as ready for review June 16, 2023 21:42
@sethkfman sethkfman requested a review from a team as a code owner June 16, 2023 21:42
Copy link
Contributor

@owencraston owencraston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cortisiko cortisiko added the release-7.1.0 Issue or pull request that will be included in release 7.1.0 label Jun 16, 2023
Copy link
Member

@Andepande Andepande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • QA Passed,
  • E2e Android passed
  • E2e IOS tests passed 2 failures that passed on re-runs and manual verification
    image
    image

@Andepande Andepande added the QA Passed A successful QA run through has been done label Jun 19, 2023
@Andepande Andepande merged commit e829488 into release/7.1.0 Jun 19, 2023
6 checks passed
@Andepande Andepande deleted the fix/7.1.0-upgrade-error branch June 19, 2023 14:30
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) QA Passed A successful QA run through has been done regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead release-7.1.0 Issue or pull request that will be included in release 7.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants