feat: add linea mainnet alert message #6632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
sethkfman
added
release-7.2.0
needs-qa
|
@cortisiko Hey, I want to review this PR with you before we merge for 7.2.0. |
cortisiko
removed
the
needs-qa
|
@sethkfman @VGau one small feedback here: we would need to ensure that the newly added strings are translated. Not a blocker for getting this PR merged into main, but we should aim to have the translations as part of the release. I will approve |
cortisiko
approved these changes
Jun 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
feat/551-add-linea-mainnetbranch because we need to have the linea mainnet network implemented to add the warning message.Screenshots/Recordings
0xaQaQud2k.mp4
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses #???
Checklist