refactor: approve and reject transactions using approval controller

[matthewwalsh0]

Description

Add a patch to the TransactionController to await the approval request being approved or rejected, before automatically performing the result logic, either signing and submitting the transaction, or cancelling it.

In addition, update all direct usage of the approveTransaction and cancelTransaction methods to instead use the ApprovalController to accept or reject the related approval request.

Checklist

• There is a related GitHub issue
• Tests are included if applicable
• Any added code is fully documented

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: micro-ftch@0.3.1, react-native-vector-icons@6.4.2, @jridgewell/set-array@1.1.1, kleur@3.0.3, cheerio@1.0.0-rc.10

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

[socket-security]

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages		Version	New capabilities	Transitives1	Size	Publisher
@metamask/approval-controller	⬆️	2.1.0...3.1.0	network	+12/-0	3.71 MB	metamaskbot

Footnotes

1. https://docs.socket.dev ↩

[matthewwalsh0]

@SocketSecurity ignore-all

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

3.7% Coverage
0.0% Duplication