Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove dead network controller code #6662

Merged
merged 1 commit into from
Jun 21, 2023
Merged

refactor: Remove dead network controller code #6662

merged 1 commit into from
Jun 21, 2023

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jun 21, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Dead code that references the network controller state has been removed. These lines were having absolutely no functional impact.

Issue

Relates to https://github.com/MetaMask/mobile-planning/issues/1016

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@Gudahtt
refactor: Remove dead network controller code
6fa7c86 
Dead code that references the network controller state has been
removed. These lines were having absolutely no functional impact.

Relates to MetaMask/mobile-planning#1016
@Gudahtt Gudahtt requested a review from a team as a code owner June 21, 2023 18:14
@Gudahtt Gudahtt added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 21, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Gudahtt Gudahtt added the No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. label Jun 21, 2023
sethkfman
sethkfman approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gudahtt Gudahtt merged commit 17cf740 into main Jun 21, 2023
14 checks passed
@Gudahtt Gudahtt deleted the remove-unused-references-to-network-controller-state branch June 21, 2023 22:26
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed/E2E Only Apply this label when your PR does not need any QA effort.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gudahtt @sethkfman