refactor: Simplify isMainnet utility function
#6664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
added
the
needs-dev-review
The `isMainnet` utility function used to accept either a network controller state object or a chain ID. Now it only accepts a chain ID. The one place where the network controller state was passed in has been updated to pass in a chain ID instead. A JSDoc comment has been added for this utility function as well. Relates to MetaMask/mobile-planning#1016
Gudahtt
force-pushed
the
simplify-is-mainnet-utility-function
branch
from
b85cb7d
to
03c8482
Compare
|
Kudos, SonarCloud Quality Gate passed! |
sethkfman
reviewed
Jun 21, 2023
Gudahtt
added
No QA Needed/E2E Only
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
The
isMainnetutility function used to accept either a network controller state object or a chain ID. Now it only accepts a chain ID. The one place where the network controller state was passed in has been updated to pass in a chain ID instead.A JSDoc comment has been added for this utility function as well.
Issue
Relates to https://github.com/MetaMask/mobile-planning/issues/1016
Checklist