refactor: Simplify engine service #6666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
added
the
needs-dev-review
The engine network service had three branches for handling controller state updates: BaseControllerV1, BaseControllerV2, and network controller. The network controller branch was identical to the BaseControllerV2 branch. They have been consolidated.
Gudahtt
force-pushed
the
simplify-engine-service
branch
from
eef1c0d
to
b318bfc
Compare
Gudahtt
added
the
No QA Needed/E2E Only
|
Kudos, SonarCloud Quality Gate passed! |
matthewwalsh0
approved these changes
Jun 27, 2023
bergarces
approved these changes
Jun 27, 2023
|
Passing android e2e tests here: https://app.bitrise.io/build/6d3f396e-cf60-41fa-895d-013dec230e40 |
github-actions
bot
removed
the
needs-dev-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
The engine network service had three branches for handling controller state updates: BaseControllerV1, BaseControllerV2, and network controller.
The network controller branch was identical to the BaseControllerV2 branch. They have been consolidated.
Issue
No related issue, just a code simplification.
Checklist